Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore CXX_STANDARD export from core library #377

Merged
merged 3 commits into from
Jul 12, 2022
Merged

Restore CXX_STANDARD export from core library #377

merged 3 commits into from
Jul 12, 2022

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Jul 9, 2022 •
edited
Loading

🦟 Bug fix

Restore CXX_STANDARD export in core library that was removed in #369 and also tests gazebosim/gz-cmake#273

Summary

Similar to gazebosim/sdformat#1072, this is mainly testing gazebosim/gz-cmake#273 using the ci_matching_branch/ trickery with osrf/homebrew-simulation@406b74a and gazebo-tooling/gazebodistro@b427433, but it does make a small improvement of its own, restoring the CXX_STANDARD export.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jul 9, 2022
@codecov
Copy link

codecov bot commented Jul 9, 2022 •
edited
Loading

Codecov Report

Merging #377 (fb25d47) into main (5758a45) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #377   +/-   ##
=======================================
  Coverage   76.77%   76.77%           
=======================================
  Files         128      128           
  Lines        5628     5628           
=======================================
  Hits         4321     4321           
  Misses       1307     1307

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5758a45...fb25d47. Read the comment docs.

@scpeters scpeters marked this pull request as ready for review July 9, 2022 21:40
@scpeters scpeters requested review from azeey and mxgrey as code owners July 9, 2022 21:40
@ahcorde
Copy link
Contributor

ahcorde commented Jul 11, 2022

@osrf-jenkins run tests please!

@scpeters scpeters merged commit 57e548f into main Jul 12, 2022
@scpeters scpeters deleted the ci_matching_branch/ticktock_find_ign_cmake branch July 12, 2022 23:12
@scpeters scpeters mentioned this pull request Sep 22, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@azeey azeey Awaiting requested review from azeey azeey is a code owner

@mxgrey mxgrey Awaiting requested review from mxgrey

Assignees
No one assigned
Labels
🌱 garden Ignition Garden
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scpeters @ahcorde